test(phase-3): 3C 快照自我更正——selectById 改成按主键取,别再拿替身的形状当现网语义
上一笔 c4cf7bab 的 invalidTaskIdFallsThroughToNotFound 那格没有证到它在 message 里
声称的东西:替身写的是「selectById(any()) 一律返回那只内存任务」,于是 taskId=0 一路
跑完了整条 happy path,golden 里那 20 行证的是**测试替身的形状**,不是现网语义。
而 commit message 与用例名都写着「非法 id 一路走到『任务不存在』」——那句当时并不成立。
改法:selectById 按主键取行(Objects.equals(id, TASK_ID) ? task : null),非法 id 在
锁外预检就得到「任务不存在」;用例改名 invalidTaskIdRejectedAsNotFound。
现在那一格读出来是 task.load id=0 status=- / thrown code=- message=任务不存在 /
lockAcquire=0 outsideLock=0 —— 这支没有 requireTaskId 那一格这件事,第一次被真证住。
其余 14 段 case 逐字节未动(diff 只有这一格),说明替身收紧没有波及其他形状。
门禁:CollectDataSubmitResultSnapshotTest 5 例(写模式)+非写模式复跑 4 passed/1 skipped,
golden 跨两个 JVM 逐字节相同。
This commit is contained in:
@@ -244,27 +244,9 @@ lock.acquire taskId=1001 waitMillis=5000 -> busy
|
||||
thrown: BusinessException code=40902 message=任务正在处理,请稍后再试
|
||||
counters lockAcquire=1 outsideLock=4 taskUpdate=0 resultUpdate=0 resultInsert=0 chunkInsert=0 scopeWrite=0 jobEnqueue=0
|
||||
|
||||
== case=invalidTaskIdFallsThroughToNotFound
|
||||
== case=invalidTaskIdRejectedAsNotFound
|
||||
storage.ensure sharedWrite=true
|
||||
task.load id=0 status=RUNNING module=COLLECT_DATA
|
||||
outsideLock filter rows=1 owner=7 dedupe=0 invalid=0
|
||||
outsideLock brandFilter accepted=1 rejected=0 queryFailed=0
|
||||
outsideLock asinCache.write country=- taskId=0 rows=1
|
||||
outsideLock recheck.enqueue n=0
|
||||
lock.acquire taskId=0 waitMillis=5000
|
||||
task.load id=0 status=RUNNING module=COLLECT_DATA
|
||||
result.selectOne -> id=2001
|
||||
chunk.selectOne -> none
|
||||
payload.storeResult key=chunk-1 len=127 hash=291c0ca80f2c
|
||||
resultItem.upsert chunk=1 accepted=1 ref=rustfs:result-chunk-1
|
||||
payload.storeChunk idx=1 len=127 hash=291c0ca80f2c
|
||||
chunk.insert scope=sub-1 idx=1/2 payload=rustfs:chunk-1 payloadHash=291c0ca80f2cd6a87cff2dad9e7dbf122f6111e9dc930c0f8dcbcc7f74bf8f46
|
||||
scope.selectOne -> none
|
||||
chunk.count -> 0
|
||||
scope.insert chunkTotal=2 received=0 completed=0 lastError=- stateJson={"phase":"RECEIVED"}
|
||||
task.update id=1001 status=RUNNING errorMessage=- successFileCount=- failedFileCount=- finishedAt=- resultJson.len=333 resultJson.hash=2f13867b410c
|
||||
task.load id=0 status=RUNNING module=COLLECT_DATA
|
||||
thrown: none
|
||||
vo: taskId=1001 resultId=2001 chunk=1/2 done=false receivedRows=1 currentChunkRows=1 dedupeFiltered=0 invalidFiltered=0 brandRejected=0 brandQueryFailed=0 finalRows=1 taskStatus=RUNNING
|
||||
counters lockAcquire=1 outsideLock=4 taskUpdate=1 resultUpdate=0 resultInsert=0 chunkInsert=1 scopeWrite=1 jobEnqueue=0
|
||||
task.load id=0 status=- module=-
|
||||
thrown: BusinessException code=- message=任务不存在
|
||||
counters lockAcquire=0 outsideLock=0 taskUpdate=0 resultUpdate=0 resultInsert=0 chunkInsert=0 scopeWrite=0 jobEnqueue=0
|
||||
|
||||
|
||||
Reference in New Issue
Block a user