fix(相似ASIN): 结果为空时把真因写进失败文案,不再建议重试生成结果文件
装配失败时原本只剩一句「请稍后重试生成结果文件」:同一份数据重跑只会得到同一份 空结果,这句建议做不到;而客户端上报的 error、行级 error/reason、分片读取失败本来 都在,只是被丢掉了。bounded/unbounded 两条路径现在都带上这些原因,并去掉做不到的 重试建议。新增归纳规则的纯函数单测,另加出口接线守卫防止文案退回。
This commit is contained in:
+17
-2
@@ -37,8 +37,12 @@ class SimilarAsinChineseMessageGuardTest {
|
||||
"modules/similarasin/service/SimilarAsinTaskService.java",
|
||||
"modules/similarasin/service/support/SimilarAsinResultWorkbookAssembler.java");
|
||||
|
||||
/** 2026-10-09 实测:TaskService 42 个出口 + Assembler 20 个出口。新增/删除出口要同步改这里。 */
|
||||
private static final int SCANNED_SITE_COUNT = 62;
|
||||
/**
|
||||
* 2026-10-09 实测:TaskService 42 个出口 + Assembler 20 个出口。
|
||||
* 2026-10-20 空结果的两条 throw 合并成一条(文案带真因)→ Assembler 19,合计 61。
|
||||
* 新增/删除出口要同步改这里。
|
||||
*/
|
||||
private static final int SCANNED_SITE_COUNT = 61;
|
||||
|
||||
/** 文案来自变量、字面量判据覆盖不到的出口,按构造点名(行号会漂)。 */
|
||||
private static final List<String> VARIABLE_FED_OUTLETS = List.of(
|
||||
@@ -71,6 +75,17 @@ class SimilarAsinChineseMessageGuardTest {
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void emptyResultFailuresMustCarryTheRealCause() throws IOException {
|
||||
String source = readSource("modules/similarasin/service/support/SimilarAsinResultWorkbookAssembler.java");
|
||||
assertThat(source)
|
||||
.as("「请稍后重试生成结果文件」在空结果场景做不到:同一份数据重跑装配还是同一份空结果")
|
||||
.doesNotContain("请稍后重试生成结果文件");
|
||||
assertThat(source)
|
||||
.as("空结果出口必须接上真因归纳(客户端上报 + 行级 error/reason + 分片读取失败)")
|
||||
.contains("emptyResultFailureDetail");
|
||||
}
|
||||
|
||||
@Test
|
||||
void everyMessageOutletStartsWithChinese() throws IOException {
|
||||
List<String> offenders = new ArrayList<>();
|
||||
|
||||
+122
@@ -0,0 +1,122 @@
|
||||
package com.nanri.aiimage.modules.similarasin.service.support;
|
||||
|
||||
import static org.assertj.core.api.Assertions.assertThat;
|
||||
|
||||
import com.nanri.aiimage.modules.similarasin.model.dto.SimilarAsinResultRowDto;
|
||||
import java.util.ArrayList;
|
||||
import java.util.List;
|
||||
import org.junit.jupiter.api.Test;
|
||||
|
||||
/**
|
||||
* 空结果失败文案:真因必须写进 error_message,且不能超过 VARCHAR(1000)。
|
||||
*
|
||||
* <p>线上 25 单(2026-10-16~20)只看到「请稍后重试生成结果文件」——同一份数据重跑装配
|
||||
* 只会得到同一份空结果,这句建议做不到;而客户端上报的原因、行级 error/reason 本来都在,
|
||||
* 只是装配阶段丢掉了。这里把归纳规则钉死。
|
||||
*/
|
||||
class SimilarAsinResultTextSupportTest {
|
||||
|
||||
@Test
|
||||
void summarizeRowFailures_countsErrorAndFallsBackToReason() {
|
||||
List<SimilarAsinResultRowDto> rows = new ArrayList<>();
|
||||
rows.add(row("aiprice 未登录", ""));
|
||||
rows.add(row("aiprice 未登录", ""));
|
||||
rows.add(row("", "商品页抓取超时"));
|
||||
rows.add(row("", ""));
|
||||
rows.add(null);
|
||||
|
||||
String summary = SimilarAsinResultTextSupport.summarizeRowFailures(rows);
|
||||
|
||||
assertThat(summary)
|
||||
.contains("「aiprice 未登录」2 行")
|
||||
.contains("「商品页抓取超时」1 行")
|
||||
.contains("另有 1 行没带错误信息");
|
||||
}
|
||||
|
||||
@Test
|
||||
void summarizeRowFailures_keepsTopThreeKindsAndCountsTheRest() {
|
||||
List<SimilarAsinResultRowDto> rows = new ArrayList<>();
|
||||
for (int i = 0; i < 5; i++) {
|
||||
rows.add(row("原因A", ""));
|
||||
}
|
||||
for (int i = 0; i < 4; i++) {
|
||||
rows.add(row("原因B", ""));
|
||||
}
|
||||
for (int i = 0; i < 3; i++) {
|
||||
rows.add(row("原因C", ""));
|
||||
}
|
||||
for (int i = 0; i < 2; i++) {
|
||||
rows.add(row("原因D", ""));
|
||||
}
|
||||
|
||||
String summary = SimilarAsinResultTextSupport.summarizeRowFailures(rows);
|
||||
|
||||
assertThat(summary).contains("「原因A」5 行").contains("「原因B」4 行").contains("「原因C」3 行");
|
||||
assertThat(summary).doesNotContain("原因D", "只列前 3 类,否则长任务会把 error_message 撑爆");
|
||||
assertThat(summary).contains("等 4 类");
|
||||
}
|
||||
|
||||
@Test
|
||||
void summarizeRowFailures_truncatesLongCause() {
|
||||
String longCause = "扩展注入失败".repeat(40);
|
||||
|
||||
String summary = SimilarAsinResultTextSupport.summarizeRowFailures(List.of(row(longCause, "")));
|
||||
|
||||
assertThat(summary).contains("…");
|
||||
assertThat(summary.length()).isLessThan(longCause.length() + 20);
|
||||
}
|
||||
|
||||
@Test
|
||||
void emptyResultFailureDetail_carriesClientErrorRowCausesAndChunkFailures() {
|
||||
String detail = SimilarAsinResultTextSupport.emptyResultFailureDetail(
|
||||
112, 112, "相似ASIN环境不可用:扩展注入失败", "「aiprice 未登录」112 行", "第 3 分片读取失败");
|
||||
|
||||
assertThat(detail)
|
||||
.contains("上传解析 112 行,客户端回传 112 行,可导出 0 行")
|
||||
.contains("客户端报告:相似ASIN环境不可用:扩展注入失败")
|
||||
.contains("行级原因:「aiprice 未登录」112 行")
|
||||
.contains("第 3 分片读取失败");
|
||||
}
|
||||
|
||||
@Test
|
||||
void emptyResultFailureDetail_neverAdvisesAnImpossibleRetry() {
|
||||
String withCause = SimilarAsinResultTextSupport.emptyResultFailureDetail(
|
||||
10, 10, "扩展注入失败", "「aiprice 未登录」10 行", "");
|
||||
String withoutCause = SimilarAsinResultTextSupport.emptyResultFailureDetail(
|
||||
10, 0, "", "", "");
|
||||
|
||||
assertThat(withCause).doesNotContain("请稍后重试");
|
||||
assertThat(withoutCause).doesNotContain("请稍后重试");
|
||||
}
|
||||
|
||||
@Test
|
||||
void emptyResultFailureDetail_explainsWhenClientUploadedNothing() {
|
||||
String detail = SimilarAsinResultTextSupport.emptyResultFailureDetail(0, 0, "", "", "");
|
||||
|
||||
assertThat(detail).contains("客户端没有回传任何结果行");
|
||||
}
|
||||
|
||||
@Test
|
||||
void emptyResultFailureDetail_explainsWhenRowsHaveNoExportableFields() {
|
||||
String detail = SimilarAsinResultTextSupport.emptyResultFailureDetail(10, 10, "", "", "");
|
||||
|
||||
assertThat(detail).contains("回传的行没有标题、图片等可导出字段");
|
||||
}
|
||||
|
||||
@Test
|
||||
void emptyResultFailureDetail_fitsErrorMessageColumn() {
|
||||
String huge = "x".repeat(5000);
|
||||
|
||||
String detail = SimilarAsinResultTextSupport.emptyResultFailureDetail(9999, 9999, huge, huge, huge);
|
||||
|
||||
assertThat(detail.length()).isLessThanOrEqualTo(901);
|
||||
assertThat(detail).endsWith("…");
|
||||
}
|
||||
|
||||
private static SimilarAsinResultRowDto row(String error, String reason) {
|
||||
SimilarAsinResultRowDto row = new SimilarAsinResultRowDto();
|
||||
row.setError(error);
|
||||
row.setReason(reason);
|
||||
return row;
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user