feat(phase-4): 京东商品图片预签名直传与登记链——服务端零图片字节

This commit is contained in:
2026-11-14 11:32:47 +08:00
parent 53e176ba7c
commit 6ce995f19e
10 changed files with 939 additions and 6 deletions
@@ -0,0 +1,255 @@
package com.nanri.aiimage.modules.jd.service;
import com.baomidou.mybatisplus.core.MybatisConfiguration;
import com.baomidou.mybatisplus.core.conditions.Wrapper;
import com.baomidou.mybatisplus.core.metadata.TableInfoHelper;
import com.nanri.aiimage.common.exception.BusinessException;
import com.nanri.aiimage.common.mapper.AdminUserMapper;
import com.nanri.aiimage.common.model.entity.AdminUserEntity;
import com.nanri.aiimage.modules.file.service.oss.OssStorageService;
import com.nanri.aiimage.modules.jd.mapper.JdProductImageMapper;
import com.nanri.aiimage.modules.jd.mapper.JdProductMapper;
import com.nanri.aiimage.modules.jd.model.dto.JdImagePresignRequest;
import com.nanri.aiimage.modules.jd.model.dto.JdImageRegisterRequest;
import com.nanri.aiimage.modules.jd.model.entity.JdProductEntity;
import com.nanri.aiimage.modules.jd.model.entity.JdProductImageEntity;
import com.nanri.aiimage.modules.jd.model.vo.JdImagePresignVo;
import com.nanri.aiimage.modules.jd.model.vo.JdImageRegisterVo;
import com.nanri.aiimage.modules.task.mapper.FileTaskMapper;
import com.nanri.aiimage.modules.task.model.entity.FileTaskEntity;
import org.apache.ibatis.builder.MapperBuilderAssistant;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.api.extension.ExtendWith;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.mockito.junit.jupiter.MockitoExtension;
import org.springframework.test.util.ReflectionTestUtils;
import java.util.List;
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.anyInt;
import static org.mockito.ArgumentMatchers.anyString;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
/**
* v1.4 Phase 4 图片入库链行为测试(蓝图 §4 Phase 4 待激活清单:JdImageStorageTest)。
*
* <p>覆盖蓝图点名的五条判据:独立桶 objectKey 服务端生成(内容寻址
* {@code jd-products/<companyId>/<sha256>.<ext>},客户端不得自造)、sha256 命中既有对象
* 不发 URL 只回既有 key、非 owner 拒绝(uid 与任务 owner 对撞,fail-closed)、
* 登记时 statObject 字节数不符进 mismatched 不落行、空 images 不落行。
* 夹具走生产接线,不反射私有方法。</p>
*/
@ExtendWith(MockitoExtension.class)
class JdImageStorageTest {
private static final Long TASK_ID = 33890L;
private static final Long USER_ID = 7L;
private static final Long OTHER_UID = 9L;
private static final Long COMPANY_ID = 2L;
private static final Long PRODUCT_ID = 5L;
private static final String SHA =
"3f2a1b4c5d6e7f8091a2b3c4d5e6f7081a2b3c4d5e6f7081a2b3c4d5e6f70812";
private static final String PRODUCT_CODE = "10036442942137";
@Mock
private FileTaskMapper fileTaskMapper;
@Mock
private JdProductMapper jdProductMapper;
@Mock
private JdProductImageMapper jdProductImageMapper;
@Mock
private AdminUserMapper adminUserMapper;
@Mock
private OssStorageService ossStorageService;
@InjectMocks
private JdProductImageIngestService service;
@BeforeAll
static void initTableInfo() {
// MP 条件构造器在纯单测里必须先初始化实体 TableInfo(JdProductSyncServiceTest 同款)
TableInfoHelper.initTableInfo(new MapperBuilderAssistant(new MybatisConfiguration(), ""),
FileTaskEntity.class);
TableInfoHelper.initTableInfo(new MapperBuilderAssistant(new MybatisConfiguration(), ""),
JdProductEntity.class);
TableInfoHelper.initTableInfo(new MapperBuilderAssistant(new MybatisConfiguration(), ""),
JdProductImageEntity.class);
}
@BeforeEach
void injectConfig() {
// @Value 出厂值在纯单测里不生效,按 application.yml 默认值显式注入
ReflectionTestUtils.setField(service, "bucket", "jd-products");
ReflectionTestUtils.setField(service, "keyPrefix", "jd-products/");
ReflectionTestUtils.setField(service, "imageMaxPerProduct", 200);
}
// ---------- 夹具 ----------
private AdminUserEntity owner() {
AdminUserEntity owner = new AdminUserEntity();
owner.setId(USER_ID);
owner.setCompanyId(COMPANY_ID);
return owner;
}
private FileTaskEntity runningTask() {
FileTaskEntity task = new FileTaskEntity();
task.setId(TASK_ID);
task.setModuleType("JD_SHOP_COLLECT");
task.setStatus("RUNNING");
task.setUserId(USER_ID);
return task;
}
private JdProductEntity productRow() {
JdProductEntity product = new JdProductEntity();
product.setId(PRODUCT_ID);
product.setCompanyId(COMPANY_ID);
product.setTaskId(TASK_ID);
product.setProductCode(PRODUCT_CODE);
return product;
}
private JdImagePresignRequest.JdImageSpecDto spec(String sha256, Long bytes, String contentType) {
JdImagePresignRequest.JdImageSpecDto spec = new JdImagePresignRequest.JdImageSpecDto();
spec.setSha256(sha256);
spec.setBytes(bytes);
spec.setContentType(contentType);
return spec;
}
private JdImagePresignRequest presignRequest(String sha256, Long bytes, String contentType) {
JdImagePresignRequest request = new JdImagePresignRequest();
request.setProductCode(PRODUCT_CODE);
request.setImages(List.of(spec(sha256, bytes, contentType)));
return request;
}
private JdImageRegisterRequest.JdImageRegDto regDto(String objectKey, Long bytes) {
return regDto(objectKey, SHA, bytes);
}
private JdImageRegisterRequest.JdImageRegDto regDto(String objectKey, String sha256, Long bytes) {
JdImageRegisterRequest.JdImageRegDto dto = new JdImageRegisterRequest.JdImageRegDto();
dto.setType("MAIN");
dto.setObjectKey(objectKey);
dto.setSha256(sha256);
dto.setBytes(bytes);
dto.setSortNo(1);
return dto;
}
private JdImageRegisterRequest registerRequest(JdImageRegisterRequest.JdImageRegDto... images) {
JdImageRegisterRequest request = new JdImageRegisterRequest();
request.setTaskId(TASK_ID);
request.setProductCode(PRODUCT_CODE);
request.setImages(List.of(images));
return request;
}
private void stubRegisterHappyPath() {
when(fileTaskMapper.selectById(TASK_ID)).thenReturn(runningTask());
when(adminUserMapper.selectById(USER_ID)).thenReturn(owner());
when(jdProductMapper.selectOne(any(Wrapper.class))).thenReturn(productRow());
}
// ---------- 判据 ----------
@Test
void 预签名按独立桶生成内容寻址objectKey() {
when(adminUserMapper.selectById(USER_ID)).thenReturn(owner());
when(ossStorageService.objectSize(eq("jd-products"), anyString())).thenReturn(-1L);
when(ossStorageService.presignObjectUpload(eq("jd-products"), anyString(), anyInt()))
.thenReturn("https://oss.aishufu.top/jd-products/2/" + SHA + ".jpg?X-Amz-Signature=signed");
JdImagePresignVo vo = service.presign(USER_ID,
presignRequest(SHA, 102400L, "image/jpeg"));
assertThat(vo.getItems()).hasSize(1);
JdImagePresignVo.Item item = vo.getItems().get(0);
// objectKey 由服务端生成:独立桶前缀 + 归属公司段 + 内容摘要 + MIME 推扩展名(蓝图 §3.3)
assertThat(item.getObjectKey()).isEqualTo("jd-products/2/" + SHA + ".jpg");
assertThat(item.getUploadUrl()).contains("X-Amz-Signature");
assertThat(item.getExpiresIn()).isEqualTo(600);
assertThat(vo.getSkipped()).isZero();
verify(ossStorageService).presignObjectUpload(eq("jd-products"),
eq("jd-products/2/" + SHA + ".jpg"), eq(600));
}
@Test
void 同公司同内容命中既有对象不发URL只回既有key() {
when(adminUserMapper.selectById(USER_ID)).thenReturn(owner());
when(ossStorageService.objectSize(eq("jd-products"), anyString())).thenReturn(102400L);
JdImagePresignVo vo = service.presign(USER_ID,
presignRequest(SHA, 102400L, "image/jpeg"));
assertThat(vo.getItems()).hasSize(1);
assertThat(vo.getItems().get(0).getObjectKey()).isEqualTo("jd-products/2/" + SHA + ".jpg");
assertThat(vo.getItems().get(0).getUploadUrl())
.as("命中既有对象:不发 PUT URL,客户端登记既有 key 不重传(AC-5)")
.isNull();
assertThat(vo.getSkipped()).isEqualTo(1);
verify(ossStorageService, never()).presignObjectUpload(anyString(), anyString(), anyInt());
}
@Test
void 非owner与缺身份一律拒绝() {
when(fileTaskMapper.selectById(TASK_ID)).thenReturn(runningTask());
// uid=9 不是任务 owner(owner=7)
assertThatThrownBy(() -> service.register(OTHER_UID, registerRequest()))
.isInstanceOf(BusinessException.class)
.hasMessageContaining("无权操作该任务的图片");
// 缺身份(JWT 解析失败且未带 uid)fail-closed
assertThatThrownBy(() -> service.register(null, registerRequest()))
.isInstanceOf(BusinessException.class)
.hasMessageContaining("无法确认调用者身份");
assertThatThrownBy(() -> service.presign(null, presignRequest(SHA, 1L, "image/jpeg")))
.isInstanceOf(BusinessException.class)
.hasMessageContaining("无法确认调用者身份");
verify(jdProductImageMapper, never()).upsertBatch(any());
}
@Test
void 登记时字节数不符进mismatched不落行() {
stubRegisterHappyPath();
when(ossStorageService.objectSize(eq("jd-products"), anyString())).thenReturn(50L);
JdImageRegisterVo vo = service.register(USER_ID,
registerRequest(regDto("jd-products/2/" + SHA + ".jpg", 102400L)));
assertThat(vo.getRegistered()).isZero();
assertThat(vo.getMismatched())
.as("statObject 实测字节与声明不符:不落行、不静默吞(蓝图 §3.3 ③ 必做项)")
.isEqualTo(1);
verify(jdProductImageMapper, never()).upsertBatch(any());
}
@Test
void 空images与非法规格不落行() {
// 空 images:显式登记口直接拒绝空载荷(无 taskId 上下文);chunk 路径空清单返回 0 不查库
assertThat(service.registerTaskImages(TASK_ID, COMPANY_ID, PRODUCT_CODE, List.of())).isZero();
assertThat(service.registerTaskImages(TASK_ID, COMPANY_ID, PRODUCT_CODE, null)).isZero();
verify(jdProductMapper, never()).selectOne(any(Wrapper.class));
verify(jdProductImageMapper, never()).upsertBatch(any());
// 非法规格(sha256 非 64 位 hex)逐条跳过,不进对撞不进 upsert
stubRegisterHappyPath();
JdImageRegisterVo vo = service.register(USER_ID,
registerRequest(regDto("jd-products/2/" + SHA + ".jpg", "短摘要", 100L)));
assertThat(vo.getRegistered()).isZero();
assertThat(vo.getSkipped()).isEqualTo(1);
assertThat(vo.getMismatched()).isZero();
verify(jdProductImageMapper, never()).upsertBatch(any());
}
}
@@ -76,6 +76,8 @@ class JdProductSyncServiceTest {
private JdStaleTaskService jdStaleTaskService;
@Mock
private TaskProgressSnapshotService taskProgressSnapshotService;
@Mock
private JdProductImageIngestService jdProductImageIngestService;
@Spy
private ObjectMapper objectMapper = new ObjectMapper();