fix(产品风险): 启动前拦掉缺筛选值,选到「在售」要用户签字

「商品列表筛选」是产品风险审批唯一的取数条件,但它只随本地队列下发、不建单落库,
选错了界面上不留任何痕迹(2026-10-17 陈先锋·德国站选成在售,白跑 7 小时)。

- listingFilters.ts 新增 productRiskFilterIssues:缺键/空串 = block(Python 端会拿
  空值去页面上找一个不存在的选项,整国以「没有需要审批的商品」假成功收尾),
  「在售」这类非风险状态 = confirm(不禁止选,但要让人知道自己选了它)。
- checkQueuePayload 开一个 extraIssues 口子给业务侧判据用:ok/needsConfirm 与
  「有 block 就不展示 confirm」这条规则仍只在 dispatch-guard 里解释一遍,
  不在组件里拼第二份结果。
This commit is contained in:
2026-10-19 19:16:52 +08:00
parent de38c3ec58
commit a97dbf7f1d
4 changed files with 152 additions and 1 deletions
@@ -0,0 +1,90 @@
import { test } from 'node:test'
import assert from 'node:assert/strict'
import {
NON_RISK_LISTING_FILTERS,
RISK_LISTING_FILTER_KEY,
productRiskFilterIssues,
} from '../src/pages/brand/components/listingFilters.ts'
import { checkQueuePayload, type GuardResult } from '../src/shared/dispatch-guard.ts'
function codes(result: GuardResult) {
return result.issues.map((issue) => issue.code)
}
function runPayload(data: Record<string, unknown>) {
return {
type: 'product-risk-resolve-run',
ts: 1,
data: { taskId: 31261, items: [{ shopName: '陈先锋' }], country_codes: ['DE'], ...data },
}
}
function guard(payload: unknown) {
return checkQueuePayload(payload, {
expectedType: 'product-risk-resolve-run',
requiredDataKeys: ['taskId'],
nonEmptyArrayKeys: ['items', 'country_codes'],
extraIssues: (d) => productRiskFilterIssues(d[RISK_LISTING_FILTER_KEY]),
})
}
// 2026-10-17 陈先锋·德国站:任务把「商品列表筛选」选成在售,394 行里 219 行没有处理入口、
// 「移除ASIN」列整片空,跑完 7 小时且事后从参数里看不出错处。这两条是那次取证留下的判据。
test('test_产品风险_缺筛选键必须拦住', () => {
const missing = productRiskFilterIssues(undefined)
assert.equal(missing.length, 1)
assert.equal(missing[0].severity, 'block', '缺键时 Python 端会去页面上找 value="" 的选项并假成功')
assert.match(missing[0].message, /risk_listing_filter/)
for (const bad of ['', ' ', null, 7]) {
assert.equal(productRiskFilterIssues(bad)[0].severity, 'block', `空值 ${String(bad)} 同样要拦`)
}
})
test('test_产品风险_非风险状态要用户签字', () => {
assert.deepEqual([...NON_RISK_LISTING_FILTERS], ['Active'])
const issues = productRiskFilterIssues('Active')
assert.equal(issues.length, 1)
assert.equal(issues[0].severity, 'confirm', '在售不是不能选,是要让人知道自己选了它')
assert.match(issues[0].message, /在售/, '文案要带选项中文名,不能只甩英文标识')
assert.match(issues[0].message, /移除ASIN/)
})
test('test_产品风险_风险状态照常放行', () => {
for (const ok of ['SearchSuppressed', 'ApprovalRequired', 'DetailPageRemoved']) {
assert.deepEqual(productRiskFilterIssues(ok), [], `${ok} 不该被拦`)
}
// 目录外的值(脏数据/老版本存的键)交给页面自己判,UI 不臆断
assert.deepEqual(productRiskFilterIssues('WhateverAmazonAdded'), [])
})
test('test_产品风险_整条载荷缺键时结构校验也救不回来', () => {
const result = guard(runPayload({}))
assert.equal(result.ok, false, '只查 taskId/items 的结构校验拦不住缺筛选值,必须靠 extraIssues')
assert.ok(codes(result).includes('product-risk.filter-missing'))
})
test('test_产品风险_选到在售时整单待确认但不算失败', () => {
const result = guard(runPayload({ [RISK_LISTING_FILTER_KEY]: 'Active' }))
assert.equal(result.ok, true, 'confirm 级不改判失败')
assert.equal(result.needsConfirm, true)
assert.match(result.message, /在售/)
})
test('test_产品风险_有阻断问题时不混展示确认项', () => {
// items 为空是 block;同时筛选值又是在售(confirm):弹窗只该出现 block 那条
const payload = { type: 'product-risk-resolve-run', data: { taskId: 1, items: [], country_codes: ['DE'],
[RISK_LISTING_FILTER_KEY]: 'Active' } }
const result = guard(payload)
assert.equal(result.ok, false)
assert.equal(result.needsConfirm, false, '有 block 时不该再问"确定继续吗"')
assert.doesNotMatch(result.message, /在售/)
})
test('test_产品风险_正常筛选值一路放行', () => {
const result = guard(runPayload({ [RISK_LISTING_FILTER_KEY]: 'DetailPageRemoved' }))
assert.equal(result.ok, true)
assert.equal(result.needsConfirm, false)
assert.deepEqual(result.issues, [])
})