From d1a3e8a214b8edcbd16c464a9d1c16e6123526ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=BB=84=E8=87=AA=E8=BE=BE?= <980324341@qq.com> Date: Fri, 9 Oct 2026 09:34:18 +0800 Subject: [PATCH] =?UTF-8?q?fix(=E5=8F=91=E5=B8=83=E9=80=9A=E9=81=93):=20?= =?UTF-8?q?=E5=BC=80=E6=9C=BA=E8=87=AA=E6=A3=80=E7=9A=84=E7=94=A8=E4=BE=8B?= =?UTF-8?q?=E4=B8=8D=E5=86=8D=E4=BE=9D=E8=B5=96"=E6=B5=8B=E8=AF=95=20class?= =?UTF-8?q?path=20=E4=B8=8A=E6=81=B0=E5=A5=BD=E6=B2=A1=E6=9C=89=E7=AB=A0"?= =?UTF-8?q?=E2=80=94=E2=80=94=E8=BF=99=E6=9D=A1=E5=89=8D=E6=8F=90=E6=AF=8F?= =?UTF-8?q?=E6=AC=A1=E6=AD=A3=E8=A7=84=E5=87=BA=E5=8C=85=E9=83=BD=E8=87=AA?= =?UTF-8?q?=E5=B7=B1=E7=BF=BB=E8=BD=AC?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 现象:mvn -o clean package 在 4138 例里报 1 红 BuildInfoLoggerTest.开机自检在没有章的classpath上会打missing(expected WARN but was INFO) - 根因:发版通道要求打包前 _git_stamp.py write,写出的 git.properties 就落在 src/main/resources 下 ⇒ 监听器读到章念 INFO,用例的"没章"前提没了。等于"正规出包必红" - 修法不是放宽断言:给 BuildInfoLogger 加 logOnBoot(Resource) 接缝,用例显式喂"不存在的资源名"(缺章必吵,级别仍是断言主体) - 另加一条接线对撞:无参监听器读的资源名与字面量 git.properties 逐一比对——常量改名时监听器念"无章"而字面量仍读到章 ⇒ 红(两侧都用常量就永远测不出来) - 两态各 9 例全绿:章存在(正规出包态)与章不存在(开发态) --- .../nanri/aiimage/config/BuildInfoLogger.java | 8 ++++- .../aiimage/config/BuildInfoLoggerTest.java | 31 ++++++++++++++++--- 2 files changed, 33 insertions(+), 6 deletions(-) diff --git a/backend-java/src/main/java/com/nanri/aiimage/config/BuildInfoLogger.java b/backend-java/src/main/java/com/nanri/aiimage/config/BuildInfoLogger.java index 251e4ab74..d196000d0 100644 --- a/backend-java/src/main/java/com/nanri/aiimage/config/BuildInfoLogger.java +++ b/backend-java/src/main/java/com/nanri/aiimage/config/BuildInfoLogger.java @@ -78,7 +78,13 @@ public class BuildInfoLogger { @EventListener(ApplicationReadyEvent.class) public void logOnBoot() { - logIt(read(new ClassPathResource(RESOURCE))); + logOnBoot(new ClassPathResource(RESOURCE)); + } + + /** 章从哪一份资源读,交给调用方:测试不必伪造 classpath, + * 也不再出现"这条用例能不能过,取决于打包前盖没盖章"那种环境前提。 */ + void logOnBoot(Resource resource) { + logIt(read(resource)); } /** 与 {@link #logOnBoot()} 分开,是为了让测试能直接喂三种形状进来,不必伪造 classpath。 */ diff --git a/backend-java/src/test/java/com/nanri/aiimage/config/BuildInfoLoggerTest.java b/backend-java/src/test/java/com/nanri/aiimage/config/BuildInfoLoggerTest.java index f123505eb..6b653aeb8 100644 --- a/backend-java/src/test/java/com/nanri/aiimage/config/BuildInfoLoggerTest.java +++ b/backend-java/src/test/java/com/nanri/aiimage/config/BuildInfoLoggerTest.java @@ -12,6 +12,7 @@ import java.util.List; import org.junit.jupiter.api.Test; import org.junit.jupiter.api.io.TempDir; import org.springframework.core.io.ByteArrayResource; +import org.springframework.core.io.ClassPathResource; import org.springframework.core.io.FileSystemResource; import org.springframework.core.io.Resource; @@ -121,15 +122,35 @@ class BuildInfoLoggerTest { } /** - * 真走一遍监听器:测试 classpath 上没有 git.properties ⇒ 必须吵出来。 - * 这条不靠反射钉注解,钉的是"开机真的会念"。 + * 章缺失 ⇒ 开机必须吵。缺的证据由显式的"不存在的资源名"提供, + * 不再依赖测试 classpath 上恰好没有 git.properties——发版通道要求打包前先盖章 + * (scripts/_git_stamp.py write),那份章就落在 src/main/resources 下,于是这条旧前提 + * 在每一次正规出包里自己翻转,把发布跑红。级别仍是断言主体:摘掉 WARN 分支这里就红。 */ @Test - void 开机自检在没有章的classpath上会打missing() { - List events = capture(() -> new BuildInfoLogger().logOnBoot()); + void 开机自检在章缺失时必须打missing锚点() { + List events = capture(() -> new BuildInfoLogger() + .logOnBoot(new ClassPathResource("git.properties.absent-for-this-test"))); assertEquals(1, events.size()); - assertEquals(Level.WARN, events.get(0).getLevel()); + assertEquals(Level.WARN, events.get(0).getLevel(), "章没念到却不吵,巡检就没法按锚点计数"); assertTrue(events.get(0).getFormattedMessage().contains(BuildInfoLogger.MISSING_ANCHOR), events.get(0).getFormattedMessage()); } + + /** + * 接线对撞:无参那个监听器读的必须就是字面量 git.properties。 + * 若有人把 RESOURCE 常量改名,监听器会念"无章",而这一侧按字面量仍能读到章 ⇒ 两边不等 ⇒ 红。 + * (两侧都同一个常量的话,改名就永远测不出来——这条特意用字面量。) + */ + @Test + void 监听器读的就是git点properties这个资源名() { + String expected = BuildInfoLogger.describe( + BuildInfoLogger.read(new ClassPathResource("git.properties"))); + List events = capture(() -> new BuildInfoLogger().logOnBoot()); + assertEquals(1, events.size()); + assertTrue(events.get(0).getFormattedMessage().contains(expected), + "监听器念的是「" + events.get(0).getFormattedMessage() + + "」,按字面量 git.properties 读出来是「" + expected + + "」⇒ 资源名漂移了"); + } }