From f3ac3cb20bed6d8038747f1e9324e908b47cb810 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=BB=84=E8=87=AA=E8=BE=BE?= <980324341@qq.com> Date: Mon, 19 Oct 2026 11:47:18 +0800 Subject: [PATCH] =?UTF-8?q?refactor(phase-3):=203A=20=E6=8B=86=E8=96=84?= =?UTF-8?q?=E2=80=94=E2=80=94=E5=BD=92=E5=B1=9E=E5=AE=9E=E4=BE=8B=E8=B0=93?= =?UTF-8?q?=E8=AF=8D=E6=94=B6=E6=88=90=20support=20=E4=BB=B6=EF=BC=8C?= =?UTF-8?q?=E6=9C=8D=E5=8A=A1=E4=BE=A7=E5=8F=AA=E7=95=99=E8=96=84=E5=A7=94?= =?UTF-8?q?=E6=89=98?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AppearancePatentTaskService 棘轮读数 3381→3349;新落 support/AppearancePatentTaskOwnership 114 行(<800 报警线,不进超长清单,readability 棘轮无需登记例外)。 形状与判据一字未改,只是换了住处:owner 优先读 owner_instance_id 列、回落 resultJson.ownerInstanceId 快照(那条 2026-09-30 内部认领实测的注释原样带过来)、 scopeKey 按 ":owner:" 尾段解析、TaskOwnerMismatchException 四枚入参顺序照旧。 服务侧留六枚 1-3 行薄委托+一处 taskOwnership() 访问器——这是本模块已有的先例 (historyAssembler() / sheetBuilder() 同样是服务内部 new 的普通对象,不是 Spring bean), 所以本笔不动构造器、不动装配、注进 wiring slice 的东西一个字节没变。 为什么现在搬:A 聚类(陈旧任务扫描与二次判死)紧接着要抽出去,它跨实例接管那格要用 同一套谓词。谓词留在服务里只有两条路——扫描件回调服务,或者再抄一遍三枚。后者正是 TaskLifecycleDebtRatchetTest 钉住的债(同一条安全谓词手抄 130 遍、只许降), 所以收成一枚可复用件,而不是多一处抄本。 ⚠ 一处可观测差异如实登记:两条 WARN 的 logger 名从 ...AppearancePatentTaskService 变成 ...service.support.AppearancePatentTaskOwnership;消息文本、级别、参数顺序一字未动。 按 logger 名做检索的人要跟着换,别读成「日志丢了」。 门禁:定向批 349 例/0 红/0 错/5 skipped(golden 生成器),BUILD SUCCESS;八条 golden 逐字节相等;CatchSilence 四格未动(搬移不改树上 catch 总数);ArchitectureBoundary 绿。 --- .../service/AppearancePatentTaskService.java | 72 ++++------- .../AppearancePatentTaskOwnership.java | 113 ++++++++++++++++++ 2 files changed, 133 insertions(+), 52 deletions(-) create mode 100644 backend-java/src/main/java/com/nanri/aiimage/modules/appearancepatent/service/support/AppearancePatentTaskOwnership.java diff --git a/backend-java/src/main/java/com/nanri/aiimage/modules/appearancepatent/service/AppearancePatentTaskService.java b/backend-java/src/main/java/com/nanri/aiimage/modules/appearancepatent/service/AppearancePatentTaskService.java index d75e04999..69e9268ca 100644 --- a/backend-java/src/main/java/com/nanri/aiimage/modules/appearancepatent/service/AppearancePatentTaskService.java +++ b/backend-java/src/main/java/com/nanri/aiimage/modules/appearancepatent/service/AppearancePatentTaskService.java @@ -36,6 +36,7 @@ import com.nanri.aiimage.modules.appearancepatent.model.vo.AppearancePatentTaskD import com.nanri.aiimage.modules.appearancepatent.model.vo.AppearancePatentTaskItemVo; import com.nanri.aiimage.modules.appearancepatent.service.support.AppearancePatentRowOutcome; import com.nanri.aiimage.modules.appearancepatent.service.support.AppearancePatentSheetBuilder; +import com.nanri.aiimage.modules.appearancepatent.service.support.AppearancePatentTaskOwnership; import com.nanri.aiimage.modules.file.service.LocalFileStorageService; import com.nanri.aiimage.modules.file.service.oss.OssStorageService; import com.nanri.aiimage.modules.task.mapper.FileResultMapper; @@ -673,8 +674,9 @@ public class AppearancePatentTaskService extends AbstractFileTaskPipeline原样搬移 + * (3A 拆薄第二笔):owner 优先读 {@code owner_instance_id} 列、回落 {@code resultJson.ownerInstanceId} + * 快照,{@code scopeKey} 按 {@code ":owner:"} 尾段解析,谓词与文案一字未改。 + * + *

为什么现在搬得动、以前搬不动。这套谓词一直只有服务侧在用;A 聚类(陈旧任务扫描与 + * 二次判死)搬出去之后也要用同一套(跨实例接管那格 WARN),留在服务里就只有两条路——让扫描件 + * 回调服务,或者把三枚谓词再抄一遍。后者正是 + * {@code TaskLifecycleDebtRatchetTest} 钉住的东西(「同一条安全谓词被手抄的遍数」,实测 130 遍 + * 只许降),所以这里选择把谓词收成一枚可复用的本地件,而不是多一处抄本。 + * + *

⚠ 一处可观测差异,如实登记:两条 WARN 的 logger 名从 + * {@code ...appearancepatent.service.AppearancePatentTaskService} 变成本类 + * ({@code ...service.support.AppearancePatentTaskOwnership})。消息文本、参数顺序、级别 + * 一个字没动;按 logger 名做的日志检索要跟着换,别把它读成「日志丢了」。 + */ +@Slf4j +public class AppearancePatentTaskOwnership { + + private static final String OWNER_MARKER = ":owner:"; + + private final InstanceMetadata instanceMetadata; + private final ObjectMapper objectMapper; + + public AppearancePatentTaskOwnership(InstanceMetadata instanceMetadata, ObjectMapper objectMapper) { + this.instanceMetadata = instanceMetadata; + this.objectMapper = objectMapper; + } + + /** 归属实例域那枚 scopeKey:本支挂组装 job 与巡检恢复都用它。 */ + public String buildTaskOwnerScopeKey(FileTaskEntity task) { + Long taskId = task == null ? null : task.getId(); + return "task:" + taskId + ":owner:" + firstNonBlank(ownerFromTask(task), currentInstanceId()); + } + + public String currentInstanceId() { + String instanceId = instanceMetadata == null ? null : instanceMetadata.getInstanceId(); + return firstNonBlank(instanceId, "unknown-instance"); + } + + /** + * 归属不符即拒。服务侧那枚 {@code protected} 覆写现在只是转发到这里—— + * {@link TaskOwnerMismatchException} 的四个入参顺序照旧(taskId/operation/owner/current)。 + */ + public void rejectIfOwnedByAnotherInstance(FileTaskEntity task, String operation) { + String owner = ownerFromTask(task); + if (isOwnerCurrent(owner)) { + return; + } + log.warn("[appearance-patent] reject task operation because owner is another instance taskId={} operation={} owner={} current={}", + task == null ? null : task.getId(), operation, owner, currentInstanceId()); + throw new TaskOwnerMismatchException( + task == null ? null : task.getId(), + operation, + owner, + currentInstanceId()); + } + + public boolean isOwnerCurrent(String owner) { + return owner == null || owner.isBlank() || Objects.equals(owner, currentInstanceId()); + } + + /** + * 优先读 {@code owner_instance_id} 列:兜底拉取认领({@code TaskClientPullService.claim})会转交该列, + * 而 {@code resultJson} 里的 {@code ownerInstanceId} 只是 parse 时的快照,转交后不同步 —— + * 只读快照会把已在别处认领的任务误拒并标失败(2026-09-30 内部认领上线实测)。 + */ + public String ownerFromTask(FileTaskEntity task) { + if (task == null) { + return null; + } + if (task.getOwnerInstanceId() != null && !task.getOwnerInstanceId().isBlank()) { + return task.getOwnerInstanceId(); + } + if (task.getResultJson() == null || task.getResultJson().isBlank()) { + return null; + } + try { + String owner = objectMapper.readTree(task.getResultJson()).path("ownerInstanceId").asText(""); + return owner.isBlank() ? null : owner; + } catch (Exception ex) { + log.warn("[appearance-patent] read task owner failed taskId={} err={}", + task.getId(), ex.getMessage()); + return null; + } + } + + public String ownerFromScopeKey(String scopeKey) { + if (scopeKey == null || scopeKey.isBlank()) { + return null; + } + int index = scopeKey.lastIndexOf(OWNER_MARKER); + if (index < 0) { + return null; + } + String owner = scopeKey.substring(index + OWNER_MARKER.length()).trim(); + return owner.isBlank() ? null : owner; + } + + private static String firstNonBlank(String preferred, String fallback) { + return preferred == null || preferred.isBlank() ? fallback : preferred.trim(); + } +}