package com.nanri.aiimage; import com.tngtech.archunit.core.domain.JavaClasses; import com.tngtech.archunit.core.importer.ClassFileImporter; import com.tngtech.archunit.core.importer.ImportOption; import org.junit.jupiter.api.Test; import static com.tngtech.archunit.lang.syntax.ArchRuleDefinition.noClasses; import static org.junit.jupiter.api.Assertions.assertTrue; /** * task-210/211/212:模块边界 ArchUnit 规则(plan 13)。 * * 已通过(零违规):任何 Controller 不得直接访问 Mapper 或外部 Client(211)。 * 债务防恶化(210/212,探针 2026-09-05):task 模块经 *ResultFileJobHandler 等依赖具体业务 * Service/Mapper 曾达 128 处、modules 切片存在 collectdata→dedupe→task 等环;Handler 已迁回 * 业务模块(212 大幅收敛)。整体模块切片无环依赖进一步 SPI 化(deletebrand 跨模块扫描/心跳等), * 尚未达成,故本文件冻结"存量不新增"上限。 */ class ArchitectureBoundaryTest { private static final int TASK_TO_BUSINESS_BASELINE = 84; private static volatile JavaClasses cached; private static JavaClasses app() { if (cached == null) { cached = new ClassFileImporter() .withImportOption(ImportOption.Predefined.DO_NOT_INCLUDE_TESTS) .importPackages("com.nanri.aiimage.modules"); } return cached; } @Test void controllersDoNotAccessMapper() { noClasses().that().resideInAPackage("..controller..") .should().dependOnClassesThat().resideInAPackage("..mapper..") .because("Controller 只经 Service 访问 Mapper(单向分层)") .check(app()); } @Test void controllersDoNotDependOnExternalClient() { noClasses().that().resideInAPackage("..controller..") .should().dependOnClassesThat().resideInAPackage("..client..") .because("外部 Client 细节由 Service 层收敛,Controller 不应感知") .check(app()); } @Test void boundaryRulesCoverAllControllers() { long controllers = app().stream() .filter(c -> c.getPackageName().endsWith(".controller")).count(); assertTrue(controllers >= 10, "应覆盖全部 Controller,实际 " + controllers); } @Test void taskToBusinessDependencyDoesNotGrow() { // 冻结存量:Handler 迁移后 task→业务 依赖已大幅收敛;不允许继续增长 int violations = countViolations(taskRule()); assertTrue(violations >= 1, "task→业务 依赖仍有存量(心跳/清理等待 SPI 化)"); assertTrue(violations <= TASK_TO_BUSINESS_BASELINE, "task→业务 依赖不得超过基线 " + TASK_TO_BUSINESS_BASELINE + ",当前 " + violations + ";新增依赖走 Handler SPI 或先消除存量"); } @Test void ruleFailuresCarryClearReason() { // 规则附 because 说明,失败信息可定位 assertTrue(taskRule().getDescription().contains("no classes that reside in a package"), "规则描述应可读"); } @Test void spiHandlersAreTheSanctionedBridge() { JavaClasses classes = app(); long handlers = classes.stream() .filter(c -> c.getSimpleName().endsWith("ResultFileJobHandler")) .count(); assertTrue(handlers >= 13, "Handler SPI 实现应在各业务模块注册,实际 " + handlers); } private static com.tngtech.archunit.lang.ArchRule taskRule() { return noClasses().that().resideInAPackage("..modules.task..") .should().dependOnClassesThat().resideInAPackage( "..modules.(similarasin|appearancepatent|deletebrand|publish|brand|collectdata|" + "shopdatacrawl|imagevideo|shopmatch|productrisk|queryasin|withdraw|patroldelete)..") .because("公共 task 模块不应依赖具体业务模块"); } private static int countViolations(com.tngtech.archunit.lang.ArchRule rule) { try { rule.check(app()); return 0; } catch (AssertionError e) { String msg = e.getMessage(); long count = msg.lines() .filter(l -> l.trim().startsWith("Constructor <") || l.trim().startsWith("Field <") || l.trim().startsWith("Method <") || l.trim().startsWith("Class <")) .count(); return (int) count; } } }