a24d7b9bac
付费客户「先锋-团队」一次报的四件事,根因各自独立,这一版一起收: 1) 去重数据汇总「新增导入」选自己公司的分组提交必 403。DedupeTotalDataService .resolveAccessScope 给 company_super_admin 时只开了 wholeCompany 那一支、groupIds 留空集,而写侧闸门 resolveWritableGroup / ensureImportTaskAccess 只认 allUsers 与 groupIds——读侧宽、写侧窄,表现就是「下拉选得到、提交就 403」,且 403 是 HTTP 状态 不是中文文案,前端只能显示 Request failed with status code 403。改为同一口径把本公司的 分组 id 一起带上(src/main/.../DedupeTotalDataService.java:86,104,112 + 注释)。 2) 「暂无分组」与「分组名称已存在」是同一行的两面:老「先锋」的组长 uid=1188 已被删, 分组 id=33 成了孤儿行,仍占着全平台唯一的组名;而 list() 只按 created_by_id 筛, 这一行被每一个公司的 tab 静默排除(生产 13 个分组里 2 个组长只落在旧列 user_id 上)。 V153 给 biz_shop_manage_group 加 company_id(建组按组长定死、改名按组长当前公司纠回, 顺手治「移人」造成的落值漂移),唯一键换成 uk_company_group_name(company_id, group_name), 先 ADD 后 DROP。校验收窄到本公司,文案也从「分组名称已存在」改成「本公司内已存在同名分组」。 MySQL 唯一索引里 NULL 互不相异 ⇒ 迁移上线后 (NULL,'先锋') 不挡 (3,'先锋'), 客户当场就能建组,不需要先清那两行孤儿数据。 3) 删号/凭证过期后「软件还能用、没有强制退出」:前端 http 拦截器只认业务码 4011(互踢), JWT 过期或被拒返回的 401 一路静默,页面停在原处。新增 handleSessionExpired(), 401 与「code/status=401」都清本地登录态并跳 /login?expired=1;匿名 401 不收口 (那是常态噪声,且没登录态可清)。403 仍不触发下线——那是权限缺口,不能说成登录坏了。 4) 互踢(客户要「支持同时登录」)走配置不改码:AIIMAGE_AUTH_SINGLE_DEVICE_ENABLED=false, 开关只有 3 个消费点、OFF 支已有用例钉着。这里只把公司超管的角色串收成 DeviceSessionPolicy.COMPANY_SUPER_ADMIN,并记下它 src/main 仍有 22 处手抄比较 (SuperAdminPredicateSingleOutletTest 那支绊线只管 super_admin,别以为它也在守这一串)。 ⚠ 本提交带着并行会话 10-07 那批分组公司归属校验一起上线(ShopManageGroupService 的 ensureLeaderSharesOperatorCompany / resolveMembers 公司校验等,约 58 行):HEAD 里这个类 连 companyScope 字段都没有,我的写侧代码压在同一处,逐 hunk 拆不出「纯本批」的一版, 拆出来的也编不过。他那支 ShopManageGroupCompanyScopeTest(5 例)一并收了,否则这 58 行进仓 却没有用例。他的 ShopKey*/AdminUserService/admin-frontend-vue 账号页那批一个字没动,仍在 工作树里等他自己发。 验证:mvn -o clean test 全量在 detached worktree(HEAD + 本批白名单)跑;定向 8 支类 61 例 0 红; shopkey+dedupe 整包 130 例 0 红;本批判据变异自证 6/6 被杀(每轮还原后与注入前哈希逐字节一致); 前端 node --test 21 例 0 红、变异 3/3。回滚:jar 单独回退即可,V153 的手术式回滚见 backend-java/docs/rollback-V153-shop-manage-group-company-id.sql(不要 DROP COLUMN,它是资产)。
164 lines
6.6 KiB
TypeScript
164 lines
6.6 KiB
TypeScript
import { test } from 'node:test'
|
||
import assert from 'node:assert/strict'
|
||
import { readFileSync } from 'node:fs'
|
||
import { fileURLToPath } from 'node:url'
|
||
import { resolve, dirname } from 'node:path'
|
||
import { onResponseFulfilled, onResponseRejected } from '../src/shared/api/http.ts'
|
||
import {
|
||
KICKED_CODE,
|
||
KICK_NOTICE_KEY,
|
||
SESSION_EXPIRED_NOTICE_KEY,
|
||
UNAUTHORIZED_CODE,
|
||
isUnauthorizedPayload,
|
||
} from '../src/shared/auth/kick-handler.ts'
|
||
|
||
const here = dirname(fileURLToPath(import.meta.url))
|
||
|
||
/** 登录页是 .vue 组件,本树无挂载测试(无 @vue/test-utils),按既有惯例用源码尺子钉。 */
|
||
const loginPageSource = readFileSync(
|
||
resolve(here, '../src/pages/login/DesktopLoginPage.vue'),
|
||
'utf-8',
|
||
)
|
||
|
||
function createStorage(initial: Record<string, string> = {}) {
|
||
const store = new Map(Object.entries(initial))
|
||
return {
|
||
getItem: (key: string) => (store.has(key) ? (store.get(key) as string) : null),
|
||
setItem: (key: string, value: string) => void store.set(key, String(value)),
|
||
removeItem: (key: string) => void store.delete(key),
|
||
}
|
||
}
|
||
|
||
function setupWindow(initial: Record<string, string> = {}, pathname = '/home') {
|
||
const localStorage = createStorage(initial)
|
||
const assigned: string[] = []
|
||
;(globalThis as Record<string, unknown>).window = {
|
||
localStorage,
|
||
location: {
|
||
pathname,
|
||
search: '',
|
||
assign: (url: string) => {
|
||
assigned.push(url)
|
||
},
|
||
},
|
||
addEventListener: () => undefined,
|
||
}
|
||
return { localStorage, assigned }
|
||
}
|
||
|
||
function loggedInStorage() {
|
||
return {
|
||
aiimage_auth_token: 'jwt-token',
|
||
uid: '1206',
|
||
username: '先锋',
|
||
aiimage_auto_login: '1',
|
||
aiimage_device_id: 'dev-fingerprint',
|
||
company_name: '厦门米椿花',
|
||
}
|
||
}
|
||
|
||
/** 后端把「未登录 / 令牌过期 / 用户不存在」都编译成 HTTP 200 + body.code=401。 */
|
||
function unauthorizedEnvelope() {
|
||
return { success: false, code: UNAUTHORIZED_CODE, message: '用户不存在' }
|
||
}
|
||
|
||
test('isUnauthorizedPayload 只认 code=401,不吞 4011 与其他码', () => {
|
||
assert.equal(isUnauthorizedPayload(unauthorizedEnvelope()), true)
|
||
assert.equal(isUnauthorizedPayload({ success: false, code: KICKED_CODE }), false)
|
||
assert.equal(isUnauthorizedPayload({ success: false, code: 403, message: '需要管理员权限' }), false)
|
||
assert.equal(isUnauthorizedPayload({ success: true, data: {} }), false)
|
||
assert.equal(isUnauthorizedPayload(null), false)
|
||
assert.equal(isUnauthorizedPayload('401'), false)
|
||
})
|
||
|
||
test('删号/令牌过期必须强制下线:清登录态、关自动登录、跳登录页', () => {
|
||
const { localStorage, assigned } = setupWindow(loggedInStorage())
|
||
|
||
const returned = onResponseFulfilled({ data: unauthorizedEnvelope() })
|
||
|
||
assert.equal(returned.success, undefined, '拦截器仍原样返回响应对象')
|
||
assert.equal(localStorage.getItem('aiimage_auth_token'), null)
|
||
assert.equal(localStorage.getItem('uid'), null)
|
||
assert.equal(localStorage.getItem('company_name'), null, '残留公司名会把上一账号的归属显示给下一个账号')
|
||
assert.equal(localStorage.getItem('aiimage_auto_login'), '0', '不关自动登录=被删账号每次启动静默重试')
|
||
assert.deepEqual(assigned, ['/login?expired=1'])
|
||
})
|
||
|
||
test('成因文案不能混用:401 不得点亮「已在其他设备登录」标记', () => {
|
||
const { localStorage } = setupWindow({ ...loggedInStorage(), [KICK_NOTICE_KEY]: '1' })
|
||
|
||
onResponseFulfilled({ data: unauthorizedEnvelope() })
|
||
|
||
assert.equal(localStorage.getItem(KICK_NOTICE_KEY), null, '登录态失效不能说成被顶下线')
|
||
assert.equal(localStorage.getItem(SESSION_EXPIRED_NOTICE_KEY), '1')
|
||
})
|
||
|
||
test('反向也要成立:4011 亮互踢标记并清掉失效标记', () => {
|
||
const { localStorage, assigned } = setupWindow({ ...loggedInStorage(), [SESSION_EXPIRED_NOTICE_KEY]: '1' })
|
||
|
||
onResponseFulfilled({ data: { success: false, code: KICKED_CODE } })
|
||
|
||
assert.equal(localStorage.getItem(SESSION_EXPIRED_NOTICE_KEY), null)
|
||
assert.equal(localStorage.getItem(KICK_NOTICE_KEY), '1')
|
||
assert.deepEqual(assigned, ['/login?kicked=1'])
|
||
})
|
||
|
||
test('真实 HTTP 401 同样收口(不只有 200 信封)', async () => {
|
||
const { localStorage, assigned } = setupWindow(loggedInStorage())
|
||
|
||
await assert.rejects(
|
||
() => onResponseRejected({ response: { status: 401, data: { message: '' } }, message: '请求失败' }),
|
||
/请求失败/,
|
||
)
|
||
|
||
assert.equal(localStorage.getItem('uid'), null)
|
||
assert.deepEqual(assigned, ['/login?expired=1'])
|
||
})
|
||
|
||
test('匿名请求的 401 不收口:本地没有令牌就不该清存储、不该整页跳', () => {
|
||
const { localStorage, assigned } = setupWindow({ aiimage_remember_user: 'someone' })
|
||
|
||
onResponseFulfilled({ data: unauthorizedEnvelope() })
|
||
|
||
assert.deepEqual(assigned, [])
|
||
assert.equal(localStorage.getItem(SESSION_EXPIRED_NOTICE_KEY), null)
|
||
assert.equal(localStorage.getItem('aiimage_remember_user'), 'someone')
|
||
})
|
||
|
||
test('已在登录页时不重复跳转(仍清理登录态)', () => {
|
||
const { localStorage, assigned } = setupWindow(loggedInStorage(), '/login')
|
||
|
||
onResponseFulfilled({ data: unauthorizedEnvelope() })
|
||
|
||
assert.equal(localStorage.getItem('uid'), null)
|
||
assert.deepEqual(assigned, [])
|
||
})
|
||
|
||
test('403 等业务错误不触发下线:那是权限缺口,不能说成登录坏了', () => {
|
||
const { localStorage, assigned } = setupWindow(loggedInStorage())
|
||
|
||
onResponseFulfilled({ data: { success: false, code: 403, message: '无权访问查询ASIN' } })
|
||
|
||
assert.equal(localStorage.getItem('uid'), '1206')
|
||
assert.deepEqual(assigned, [])
|
||
})
|
||
|
||
// ---------- 登录页接线(.vue 无挂载测试,源码尺子钉三条) ----------
|
||
|
||
test('登录页认 expired 导航:显示失效提示并关掉自动登录', () => {
|
||
assert.match(loginPageSource, /function isSessionExpiredNav\(\): boolean/, '缺 expired 判定入口')
|
||
assert.match(loginPageSource, /get\('expired'\) === '1'/, '未读 ?expired=1(整页跳转带的标记)')
|
||
assert.match(loginPageSource, /lsGet\(SESSION_EXPIRED_NOTICE_KEY\)/, '未读 localStorage 兜底标记(守卫会吞 query)')
|
||
assert.match(loginPageSource, /expiredNotice\.value = true/, '判定到了却没显示提示')
|
||
assert.match(loginPageSource, /kickedNotice\.value \|\| expiredNotice\.value/, '自动登录没被一起关掉')
|
||
})
|
||
|
||
test('失效提示不得复用互踢那句文案', () => {
|
||
const expiredLine = loginPageSource
|
||
.split('\n')
|
||
.find((line) => line.includes('v-if="expiredNotice"')) || ''
|
||
assert.ok(expiredLine, '模板里没有 expiredNotice 那一行')
|
||
assert.ok(!expiredLine.includes('其他设备'), '失效提示不能说成"已在其他设备登录"')
|
||
assert.match(expiredLine, /请重新登录/)
|
||
})
|