perf(similar-asin): 缺图逐格告警降为 DEBUG,避免单任务万条 WARN 阻塞日志队列
This commit is contained in:
+4
-1
@@ -656,7 +656,10 @@ public class SimilarAsinImageEmbedder {
|
||||
: null;
|
||||
if (recovered == null) {
|
||||
imageSpool.countedBlankCell();
|
||||
log.warn("[similar-asin][image] cell-image-miss url={} colIdx={} ({}), leave blank",
|
||||
// 逐格 WARN 曾把单任务刷出 10,545 条(峰值 6,426 行/秒,超过 AsyncAppender
|
||||
// 8192 队列并阻塞业务线程);缺口汇总由 assembler 的
|
||||
// "result delivery incomplete" 与 "image spool closed" 统一输出,这里只留调试明细。
|
||||
log.debug("[similar-asin][image] cell-image-miss url={} colIdx={} ({}), leave blank",
|
||||
trimmedUrl, colIdx, alreadyFailed ? "prefetch failed" : "prefetch did not spool");
|
||||
return null;
|
||||
}
|
||||
|
||||
+83
@@ -0,0 +1,83 @@
|
||||
package com.nanri.aiimage.modules.similarasin.service.support;
|
||||
|
||||
import ch.qos.logback.classic.Level;
|
||||
import ch.qos.logback.classic.Logger;
|
||||
import ch.qos.logback.classic.spi.ILoggingEvent;
|
||||
import ch.qos.logback.core.read.ListAppender;
|
||||
import com.nanri.aiimage.common.excel.WpsCellImageWriter;
|
||||
import com.nanri.aiimage.modules.file.service.oss.OssStorageService;
|
||||
import com.nanri.aiimage.modules.similarasin.service.support.SimilarAsinImageEmbedder.ImageSpool;
|
||||
import org.apache.poi.ss.usermodel.Row;
|
||||
import org.junit.jupiter.api.AfterEach;
|
||||
import org.junit.jupiter.api.Test;
|
||||
import org.junit.jupiter.api.extension.ExtendWith;
|
||||
import org.mockito.Mock;
|
||||
import org.mockito.junit.jupiter.MockitoExtension;
|
||||
import org.slf4j.LoggerFactory;
|
||||
|
||||
import java.nio.file.Files;
|
||||
import java.util.HashMap;
|
||||
|
||||
import static org.junit.jupiter.api.Assertions.assertEquals;
|
||||
import static org.junit.jupiter.api.Assertions.assertNull;
|
||||
import static org.mockito.Mockito.mock;
|
||||
|
||||
/**
|
||||
* 线上 32358:单任务 10,545 个缺图单元格各写一条 WARN,峰值 6,426 行/秒,
|
||||
* 超过 logback AsyncAppender 的 8192 队列容量。缺口汇总已由 assembler 的
|
||||
* "result delivery incomplete" 与 "image spool closed" 输出,逐格明细降为 DEBUG。
|
||||
*/
|
||||
@ExtendWith(MockitoExtension.class)
|
||||
class SimilarAsinImageEmbedderLogVolumeTest {
|
||||
|
||||
@Mock
|
||||
private OssStorageService ossStorageService;
|
||||
|
||||
private SimilarAsinImageEmbedder embedder;
|
||||
|
||||
@AfterEach
|
||||
void shutdown() {
|
||||
if (embedder != null) {
|
||||
embedder.shutdown();
|
||||
}
|
||||
}
|
||||
|
||||
@Test
|
||||
void per_cell_image_miss_is_debug_not_warn() throws Exception {
|
||||
embedder = new SimilarAsinImageEmbedder(null, ossStorageService);
|
||||
Logger logger = (Logger) LoggerFactory.getLogger(SimilarAsinImageEmbedder.class);
|
||||
Level previous = logger.getLevel();
|
||||
boolean previousAdditive = logger.isAdditive();
|
||||
ListAppender<ILoggingEvent> appender = new ListAppender<>();
|
||||
appender.start();
|
||||
logger.addAppender(appender);
|
||||
logger.setAdditive(false);
|
||||
logger.setLevel(Level.DEBUG);
|
||||
ImageSpool spool = null;
|
||||
try {
|
||||
spool = new ImageSpool(Files.createTempDirectory("image-miss-log-test-"));
|
||||
String url = "https://example.invalid/missing.jpg";
|
||||
spool.markPrefetchFailed(url);
|
||||
WpsCellImageWriter.Session session = WpsCellImageWriter.createSession();
|
||||
Row row = mock(Row.class);
|
||||
for (int i = 0; i < 100; i++) {
|
||||
assertNull(embedder.embedAsExcelCellImage(
|
||||
i, 0, url, row, new HashMap<>(), session, spool));
|
||||
}
|
||||
assertEquals(100, spool.blankCells());
|
||||
long warn = appender.list.stream()
|
||||
.filter(event -> event.getLevel() == Level.WARN).count();
|
||||
long debug = appender.list.stream()
|
||||
.filter(event -> event.getLevel() == Level.DEBUG).count();
|
||||
assertEquals(0, warn, "逐格缺图不应再写 WARN;汇总由 assembler 统一输出");
|
||||
assertEquals(100, debug);
|
||||
} finally {
|
||||
logger.detachAppender(appender);
|
||||
logger.setAdditive(previousAdditive);
|
||||
logger.setLevel(previous);
|
||||
if (spool != null) {
|
||||
spool.close();
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user